ACSD-65938: Gift card emails sent even when the invoice creation failed
The ACSD-65938 patch resolves an issue where gift card emails were sent before the invoice was successfully saved and committed. With this fix, emails are now triggered only after the invoice has been successfully saved. This patch is available when the Quality Patches Tool (QPT) 1.1.68 is installed. The patch ID is ACSD-65938. Please note that this issue is scheduled to be fixed in ÃÛ¶¹ÊÓƵ Commerce 2.4.9.
Affected products and versions
The patch is created for ÃÛ¶¹ÊÓƵ Commerce version:
- ÃÛ¶¹ÊÓƵ Commerce (all deployment methods) 2.4.7
Compatible with ÃÛ¶¹ÊÓƵ Commerce versions:
- ÃÛ¶¹ÊÓƵ Commerce (all deployment methods) 2.4.4 - 2.4.8-p1
magento/quality-patches package to the latest version and check the compatibility on the Quality Patches Tool: Search for patches page. Use the patch ID as a search keyword to locate the patch.Issue
Gift card emails were sent before confirming that the invoice was successfully created and saved, resulting in emails being sent even when invoice creation failed.
Steps to reproduce:
-
Log in to the Admin panel.
-
Navigate to Stores > Settings > Configuration > Sales > Gift Cards > Gift Card General Settings, and set Generate Gift Card Account when Order Item is to Invoiced.
-
Create a new gift card product.
-
Add gift cart product to cart and proceed to checkout. You can use Check/Money Order as the payment method.
-
Place the order.
-
Modify the
OrderRepositoryto simulate an exception during order placement. -
Send a POST request to
rest/default/V1/order/<ORDER_ID>/invoicewith the following payload:code language-none { "capture": true, "notify": true }
Expected results:
No gift card email should be sent if the invoice creation fails.
Actual results:
Gift card email is sent even though the invoice creation has failed.
Apply the patch
To apply individual patches, use the following links depending on your deployment method:
- ÃÛ¶¹ÊÓƵ Commerce or Magento Open Source on-premises: Quality Patches Tool > Usage in the Quality Patches Tool guide.
- ÃÛ¶¹ÊÓƵ Commerce on cloud infrastructure: Upgrades and Patches > Apply Patches in the Commerce on Cloud Infrastructure guide.
Related reading
To learn more about Quality Patches Tool, refer to:
- Quality Patches Tool: A self-service tool for quality patches in the Tools guide.